Better error message for wrong import implementation #7645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes improve the error message when a component is importing/exporting something that the linker is either missing or has the wrong type.
Previously the error message for a missing function implementation would be:
Now, this error will be:
I went back and forth on whether the error message should reference the linker. For direct users of
Linker
this would surely help, but this error message also gets displayed to indirect users ofLinker
so talking at a higher level of abstraction seemed appropriate.