Rename -S common to -S cli.
#8166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:docs
alexcrichton
approved these changes
Mar 18, 2024
The "common" in `-S common` came from "wasi-common" which came from the idea of having code in common between Wasmtime, Lucet, and others. It doesn't have a clear meaning for end users, and has a risk of being interpreted as "common" functionality that's generally available everywhere. This PR renames `-S common` to `-S cli`, and documents it as including the WASI CLI APIs, to clarify its purpose `-S common` is still accepted, with a warning.
sunfishcode
force-pushed
the
sunfishcode/cli
branch
from
e656e8c to
08ab034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "common" in
-S commoncame from "wasi-common" which came from the idea of having code in common between Wasmtime, Lucet, and others. It doesn't have a clear meaning for end users, and has a risk of being interpreted as "common" functionality that's generally available everywhere.This PR renames
-S commonto-S cli, and documents it as including the WASI CLI APIs, to clarify its purpose-S commonis still accepted, with a warning.