Bump MSRV to 1.75.0 #8205
Merged
Bump MSRV to 1.75.0 #8205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coupled with today's release of 1.77.0. Today's release actually has some nice functions and such I think we'll want to use in Wasmtime but we'll need to wait 3 months to be able to use them.
fitzgen
approved these changes
Mar 21, 2024
alexcrichton
commented
Mar 21, 2024
| @@ -48,7 +48,7 @@ impl BackendFromDir for OnnxBackend { | |||
| } | |||
| } | |||
|
|
|||
| struct ONNXGraph(Arc<Mutex<Session>>, ExecutionTarget); | |||
| struct ONNXGraph(Arc<Mutex<Session>>, #[allow(dead_code)] ExecutionTarget); | |||
There was a problem hiding this comment.
cc @devigned I had to add this as it's a new warning in rustc, and I'm not sure if this indicates a bug where this should have been used or if it should be removed.
There was a problem hiding this comment.
Thank you for the heads up. I'll take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coupled with today's release of 1.77.0. Today's release actually has some nice functions and such I think we'll want to use in Wasmtime but we'll need to wait 3 months to be able to use them.