wasmtime-wasi-http collection of small refactors #8332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
…equest This rename makes the role of the type easier to understand and draws a bigger difference between it and HostOutgoingRequest. Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
The authority is already encoded in the request itself. Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Calling a public type "internal" seems strange. This also adds docs to the type.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Don't require implementors to do resource management.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
|
CI is failing, but I'm going to wait for an initial review before proceeding with fixing it. |
alexcrichton
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of refactors of
wasmtime-wasi-httpin an attempt to make the API slightly easier to use and more documented.The various refactorings are all small enough that it seems appropriate to batch them into one PR. Each individual commit should be reviewable as a standalone refactor and any of them should be able to be dropped from the PR should there not be consensus that the refactor is appropriate.