Move SingleFunctionCompiler into its own crate, cranelift-simplecompiler #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to avoid dependency cycles between cranelift-filetests and cranelift-interpreter
github-actions
bot
added
the
cranelift
Subscribe to Label Actioncc @bnjbvr
This issue or pull request has been labeled: "cranelift"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
cc: @alexcrichton, @yurydelendik: I saw that you were moving stuff around in wasmtime-jit in #1761 and wondered if you had any better ideas of where to put this |
|
Ah I think #1761 is largely just juggling wasmtime data structures and the code produced by cranelift, so I don't think it's too too connected to this. As for how this is organized, I don't have too many opinions myself! |
|
Too old! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with using this together with
cranelift-interpreter, I realized that havingSingleFunctionCompilerincranelift-filetestscreates a circular dependency. Moving this functionality out to its own crate breaks that cycle. I am quite open to other approaches (merge together with simplejit somehow?) or crate name suggestions.