Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix srem.{i8,i16} #2828

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix srem.{i8,i16} #2828

merged 1 commit into from
Apr 13, 2021

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Apr 13, 2021

Fixes one half of #2826.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Apr 13, 2021

Doc failure is unrelated.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Apr 13, 2021
@bjorn3
Copy link
Contributor Author

bjorn3 commented Apr 13, 2021

Nightly seems to break things.

cfallin
cfallin approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin
Copy link
Member

cfallin commented Apr 13, 2021

Just fixed CI in #2830 -- if you rebase on top of that, I think CI should be fixed here.

@cfallin cfallin merged commit f222802 into bytecodealliance:main Apr 13, 2021
@bjorn3 bjorn3 mentioned this pull request Apr 14, 2021
Closed
@bjorn3 bjorn3 deleted the fix_srem_i8 branch April 14, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @cfallin