Correct the value of size_of_vmmemory_definition_current_length. #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
May 21, 2021
|
The change to |
|
I think this ended up getting fixed the other way in #3013, but do you still want to land the comment changes here? |
This forward-ports the relevant parts of bytecodealliance#1396.
sunfishcode
force-pushed
the
refactor-instance
branch
from
b7d2b6a to
b228006
Compare
|
I've now updated this to just add the comment changes. |
wgwoods
pushed a commit
to wgwoods/wasmtime
that referenced
this pull request
Jul 29, 2021
…ealliance#2925) This forward-ports the relevant parts of bytecodealliance#1396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update various comments and asserts. This forward-ports the relevant
parts of #1396.