make Module::deserialize's version check optional via Config #2945
Conversation
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "cranelift", "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
| @@ -329,7 +329,7 @@ impl<'a> SerializedModule<'a> { | |||
| Ok(bytes) | |||
| } | |||
|
|
|||
| pub fn from_bytes(bytes: &[u8]) -> Result<Self> { | |||
| pub fn from_bytes(bytes: &[u8], check_version: bool) -> Result<Self> { | |||
There was a problem hiding this comment.
I think the check_version = false version should be unsafe as it is much easier to get wasmtime to interpret caches from a different wasmtime version to be interpreted incorrectly in such a way that you get UB.
There was a problem hiding this comment.
I disagree, the deserialize function is already unsafe, so this should just add caveat there to the documentation.
| @@ -329,7 +329,7 @@ impl<'a> SerializedModule<'a> { | |||
| Ok(bytes) | |||
| } | |||
|
|
|||
| pub fn from_bytes(bytes: &[u8]) -> Result<Self> { | |||
| pub fn from_bytes(bytes: &[u8], check_version: bool) -> Result<Self> { | |||
There was a problem hiding this comment.
I disagree, the deserialize function is already unsafe, so this should just add caveat there to the documentation.
A SerializedModule contains the CARGO_PKG_VERSION string, which is checked for equality when loading. This is a great guard-rail but some users may want to disable this check (e.g. so they can implement their own versioning scheme)
pchickey
force-pushed
the
pch/validate_module_version
branch
from
9d15c09 to
c270b39
Compare
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Based on #2897 - draft until that PR lands.
A SerializedModule contains the CARGO_PKG_VERSION string, which is
checked for equality when loading. This is a great guard-rail but
some users may want to disable this check (e.g. so they can implement
their own versioning scheme)