-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #3063 to the stable branch #3079
Conversation
* Restore POSIX signal handling on MacOS behind a feature flag As described in Issue #3052, the switch to Mach Exception handling removed `unix::StoreExt` from the public API of crate on MacOS. That is a breaking change and makes it difficult for some application to upgrade to the current stable Wasmtime. As a workaround this PR introduces a feature flag called `posix-signals-on-macos` that restores the old behaviour on MacOS. The flag is disabled by default. * Fix test guard * Fix formatting in the test
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Thanks for this! AFAIK though we don't really have any guidelines about what's backported and what historical versions are maintained or not. So far we have only backported and done a point release once, and that was for a security fix. Is upgrading to the current |
Right, I was also wondering if there is a process for backporting.
Yep, we can update to it although it will take some time to adjust our code to the API redesign that happened in 0.28.0. My only concern is the stability of that version. My understanding was that 0.26.1 is the current stable version suitable for production whereas the newer versions may have less coverage and may be unstable. Is this not correct? |
If anything this is the process of backporting, we just haven't written it down anywhere or really exercised it that much. (we also don't have any process yet to determine what changes should be backported, a security fix was just sort of "obviously correct" to backport) In terms of stability and production-ready-ness all recent Wasmtime versions should suffice. We mostly make new releases for releasing new features. Currently we don't have a notion of a "stable release" or similar. We hope to signal this soon with a 1.0 release that additionally signals a level of API stability, but in the meantime the quality of the implementation of 0.26 should be the same as 0.28 and beyond. |
Thank you for the clarification! That sounds good. I assumed too much based on the branch name I'll start working on updating our codebase to the |
FWIW if this is urgent and updating to 0.28 in a reasonable timeframe isn't feasible I don't think we have a policy against backports like this, we'd just probably need to discuss it with a few more folks other than just me |
@alexcrichton thanks, I'll keep that in mind and may come back to it if other options do not work out. |
This patch is taken from bytecodealliance#3079 which in turn a cherry-pick of bytecodealliance#3063 adjusted for v0.26: bytecodealliance#3063 - Restore POSIX signal handling on MacOS behind a feature flag As described in Issue bytecodealliance#3052, the switch to Mach Exception handling removed unix::StoreExt from the public API of crate on MacOS. That is a breaking change and makes it difficult for some application to upgrade to the current stable Wasmtime. As a workaround this PR introduces a feature flag called posix-signals-on-macos that restores the old behaviour on MacOS. The flag is disabled by default. - Fix test guard - Fix formatting in the test
As described in Issue #3052, the switch to Mach Exception handling
removed
unix::StoreExt
from the public API of crate on MacOS.That is a breaking change and makes it difficult for some
application to upgrade to the current stable Wasmtime.
As a workaround this PR introduces a feature flag called
posix-signals-on-macos
that restores the old behaviour on MacOS.The flag is disabled by default.
Fix test guard
Fix formatting in the test