Remove the lightbeam backend #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the Lightbeam backend from Wasmtime as per [RFC 14]. This backend hasn't received maintenance in quite some time, and as [RFC 14] indicates this doesn't meet the threshold for keeping the code in-tree, so this commit removes it. A fast "baseline" compiler may still be added in the future. The addition of such a backend should be in line with [RFC 14], though, with the principles we now have for stable releases of Wasmtime. I'll close out Lightbeam-related issues once this is merged. [RFC 14]: bytecodealliance/rfcs#14
bjorn3
approved these changes
Sep 27, 2021
| @@ -155,10 +146,6 @@ struct CommonOptions { | |||
| #[structopt(long, parse(from_os_str), value_name = "CONFIG_PATH")] | |||
| config: Option<PathBuf>, | |||
|
|
|||
| /// Use Cranelift for all compilation | |||
| #[structopt(long, conflicts_with = "lightbeam")] | |||
| cranelift: bool, | |||
There was a problem hiding this comment.
Maybe keep this for in the future if a new backend is added?
There was a problem hiding this comment.
This can be added in the future and otherwise I think it would be confusing to have a flag that basically does nothing.
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen, @peterhuene
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "fuzzing", "lightbeam", "wasmtime:c-api", "wasmtime:docs"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Sep 27, 2021
| /// Lightbeam, and currently it will always pick Cranelift. This default may | ||
| /// change over time though. | ||
| /// Automatically picks the compilation backend, currently always defaulting | ||
| /// to Cranelift. | ||
| WASMTIME_STRATEGY_AUTO, | ||
|
|
||
| /// Indicates that Cranelift will unconditionally use Cranelift to compile |
There was a problem hiding this comment.
Pre-existing, but s/Cranelift will unconditionally use Cranelift/Wasmtime will unconditionally use Cranelift/ ?
docs/contributing-architecture.md
Outdated
| are not implemented today just yet. Additionally the Lightbeam compiler has | ||
| not received maintenance in a long time, so effectively everyone uses | ||
| Cranelift. | ||
| and currently the Cranelift can be used for compiling. It is a goal of |
This was referenced Sep 27, 2021
This was referenced Sep 27, 2021
Closed
Closed
kpreisser
added a commit
to kpreisser/wasmtime-dotnet
that referenced
this pull request
Oct 22, 2022
The corresponding value (WASMTIME_STRATEGY_LIGHTBEAM) was removed with bytecodealliance/wasmtime#3390 (Wasmtime 0.31.0).
peterhuene
pushed a commit
to bytecodealliance/wasmtime-dotnet
that referenced
this pull request
Oct 24, 2022
The corresponding value (WASMTIME_STRATEGY_LIGHTBEAM) was removed with bytecodealliance/wasmtime#3390 (Wasmtime 0.31.0).
github-merge-queue bot
pushed a commit
to near/nearcore
that referenced
this pull request
Jun 13, 2024
Lightbeam backend has been removed from wasmtime all the way back in 2021. The supporting code we have here won't build, and we don't test it either. bytecodealliance/wasmtime#3390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the Lightbeam backend from Wasmtime as per RFC 14.
This backend hasn't received maintenance in quite some time, and as RFC
14 indicates this doesn't meet the threshold for keeping the code
in-tree, so this commit removes it.
A fast "baseline" compiler may still be added in the future. The
addition of such a backend should be in line with RFC 14, though, with
the principles we now have for stable releases of Wasmtime. I'll close
out Lightbeam-related issues once this is merged.