InstancePre can impl Clone #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its a manually written impl, not a derive, because InstancePre<T>: Clone does not require T: Clone. The clone should be reasonably inexpensive: Clone for Module is just an Arc, and Clone for Definition should also just be an Arc on the HostFunc or Instance variants. An InstancePre shouldnt contain any Definition::Extern variants because there is not yet a Store associated with it- right?
pchickey
force-pushed
the
pch/instance_pre_clone
branch
from
cb6bcc9 to
ee153bf
Compare
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a manually written impl, not a derive, because
InstancePre<T>: Cloneis not bound by
T: Clone.The clone should be reasonably inexpensive: Clone for
Moduleis just anArc, and Clone for
Definitionshould also just be an Arc on theHostFuncor
Instancevariants. AnInstancePreshouldnt contain anyDefinition::Externvariants because there is not yet aStoreassociatedwith it- right?