Disable cranelift's verifier by default #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of the `wasmtime` crate was to disable this verifier by default, but it looks like cranelift actually has it turned on by default which was making our documentation incorrect! This was discovered by seeing a number of timeouts when fuzzing. The debug verifier is great for fuzzing, however, so fuzzing is updated to enable this unconditionally, meaning we'll still have timeouts. For general users though this should make the documentation correct that the `wasmtime` crate, by default, disables the debug verifier.
|
Would it make sense to enable the verifier when |
|
Unfortunately An alternative though would be to do what the CLI does, enable the debug verifier based on |
sunfishcode
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the
wasmtimecrate was to disable this verifier bydefault, but it looks like cranelift actually has it turned on by
default which was making our documentation incorrect!
This was discovered by seeing a number of timeouts when fuzzing. The
debug verifier is great for fuzzing, however, so fuzzing is updated to
enable this unconditionally, meaning we'll still have timeouts. For
general users though this should make the documentation correct that the
wasmtimecrate, by default, disables the debug verifier.