-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the new canonical ABI #201
Comments
IntoFunc
not implemented for Wasmtime
#134
Ok I think all the major pieces that can be done now are largely done. The remaining bits sort of need questions and topics on #214 to be settled first. For example post-return-style things aren't done but functions aren't guaranteed to have a post-return so it doesn't make sense for the host generators to implement something with post-return as-is. |
I'm going to close this in favor of #314 since the remaining few items here and there that need to be covered by hosts I think require deeper refactorings to fully address or they're inconsequential to not really matter a whole lot. |
@alexcrichton I have a question regarding (since all the 'favored' issues are closed):
wit-bindgen version 0.24.0 still generates |
It can theoretically yeah but it would be a bit of a nontrivial lift. I didn't handle that during this whole transition due to the complexity involved, but I forgot to open another tracking issue. If you're up for it would you be ok opening a new issue for it? |
Seems the issue wasn't raised? I've done that now because this is a painful restriction. Apologies if it's a dupe. |
I've started sending PRs to do this, but I figured it'd also be a good thing to write things down:
post-return
instead of individualfree
callsunion
typeoption
typeexpected
typeenum
typetuple
typeflags
type*.witx
char8
andusize
f32
andf64
tofloat32
andfloat64
variant
ABI w.r.t. the "join" functionstring
type fromlist<char>
bool
typeunit
type(I'll probably add to this over time as I remember things)
The text was updated successfully, but these errors were encountered: