Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more serious testing #28

Open
5 tasks
c-cube opened this issue Dec 10, 2021 · 4 comments
Open
5 tasks

more serious testing #28

c-cube opened this issue Dec 10, 2021 · 4 comments
Assignees

Comments

@c-cube
Copy link
Owner

c-cube commented Dec 10, 2021

maybe depend on conf-curl/ocurl/curly to do the tests?

  • test gzip decoding (upload with compression enabled?)
  • test gzip encoding (see echo.ml and /zcat/file endpoint)
  • test routing
  • have a stupid middleware to instrument stats, do 10k calls, see if the stats match expectations
  • have a stupid middleware that adds a header to response (X-tested: ok?)

for gzip: we can use a select expression in dune, to avoid a hard dependency on it.

@craff
Copy link
Contributor

craff commented Jan 15, 2023

And you can assign me to this task (i you want), I will need the same test for simple_httpd like the one for my PR #50 which
is not very necessary for tiny_httpd compared to simple_httpd.

@craff
Copy link
Contributor

craff commented Jan 15, 2023

Do you mind if http_of_dir move to the tiny_httpd_camlzip package to have a compress option. This would
give a simple way to test compression and also allow more use case of http_of_dir.

@c-cube
Copy link
Owner Author

c-cube commented Jan 18, 2023

I think we can keep http_of_dir in the tiny_httpd package, but use the select expression in dune to have an optional dep on tiny_httpd_camlzip. I can give more details on how that works.

@craff
Copy link
Contributor

craff commented Jan 18, 2023

Yes please, if you can give me details, I could use them for Simple_httpd too.
I have ssl support (was easy to do with ocaml-ssl), but it is not easy to separate, the easiest would be to have a fake SSl module with the same interface. But I struggle with opam to do that. Ideally, I would like opam option to refer to separate git branch if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants