Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cosmic importer for new cosmic datafiles #10054

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

MatthijsPon
Copy link
Contributor

@MatthijsPon MatthijsPon commented Feb 28, 2023

Update Cosmic data importer to parse Legacy ID and recognise new HGSVp nomenclature

ImportCosmicData.java
COSV identifiers do not map to the COSMIC webpage correctly, COSM identifiers are still present in INFO string, take these as COSMIC IDs.

MutationKeywordUtils.java
Line 153 - Frameshift was not recognised when starting at stop codon.
Line 169 - Add other silent mutation options
Line 184 - Insertion just before stop codon not recognised (A101_*102insAA)
Line 189-194 - New HGSVp keyword ext, implemented as insertion
Line 196-200 - New HGSVp keyword dup, implemented as insertion
Line 226 - New HGSVp keyword delins, added to existing delins-like structure

  • Line 230 - Edited matching group to reflect new changes at line 226
    Line 242-246 - New HGSVp keyword delins with 1 del and >1 ins, not captured by an earlier regex
    Line 248-261 - New HGSVp keyword delext implemented in a similar structure as delins, excluding n1 > n2 option, as this would not be a delext

TestMutationKeywordUtils.java
Added tests for new implementations.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell B 16 Code Smells

0.0% 0.0% Coverage
16.0% 16.0% Duplication

Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants