Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/10133 exclude clinical attributes with low priority #10156

Conversation

haynescd
Copy link
Collaborator

@haynescd haynescd commented May 3, 2023

Fix #10133
Describe changes proposed in this pull request:
Update Validator to allow priority values >= -1 and update documentation (This is to disable Clinical Attribute charts when priority is set to -1)

@haynescd haynescd requested review from alisman and inodb May 3, 2023 15:33
@haynescd haynescd self-assigned this May 3, 2023
@haynescd haynescd requested a review from dippindots May 4, 2023 14:38
@inodb inodb requested a review from pvannierop May 5, 2023 14:37
@inodb inodb force-pushed the feature/10133-Exclude-Clinical-Attributes-with-low-priority branch from 0011432 to 45ce1a6 Compare May 8, 2023 14:33
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haynescd haynescd force-pushed the feature/10133-Exclude-Clinical-Attributes-with-low-priority branch from 45ce1a6 to 9dec4ae Compare May 23, 2023 19:26
@haynescd haynescd force-pushed the feature/10133-Exclude-Clinical-Attributes-with-low-priority branch from 9dec4ae to d07e617 Compare May 24, 2023 19:38
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haynescd haynescd merged commit d0b7a1d into cBioPortal:master May 24, 2023
@haynescd haynescd deleted the feature/10133-Exclude-Clinical-Attributes-with-low-priority branch May 24, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For clinical attributes with priority=-1, exclude them from add charts list
3 participants