Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two sided fishers test #10288

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Two sided fishers test #10288

merged 1 commit into from
Aug 1, 2023

Conversation

gblaih
Copy link
Contributor

@gblaih gblaih commented Jul 19, 2023

Fix #9943

@gblaih gblaih force-pushed the two-sided-fisher-test branch from 07136cd to 7c3869b Compare July 19, 2023 21:07
@alisman alisman requested a review from dippindots July 20, 2023 14:39
dippindots
dippindots approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gblaih This looks good to me! Good job!

@dippindots
Copy link
Member

There is one more thing, I noticed that there are two tests that have the q value changed. I will try to rebase your pr to the latest master and let it run another time. If those two tests still show different q values, let's find out why.

@dippindots dippindots force-pushed the two-sided-fisher-test branch from 7c3869b to fae6d16 Compare July 20, 2023 18:22
@dippindots
Copy link
Member

@gblaih Comparing our master branch test results, there are two more failing tests. Could you investigate why we have these two tests changed?
results_view_comparison_tab_alteration_enrichments_two_groups and group_comparison_alteration_enrichments_two_groups See tests here: https://app.circleci.com/pipelines/github/cBioPortal/cbioportal/5705/workflows/0e3a10d9-48b5-4e7e-acd9-f9c40b05c1a7/jobs/18013/tests

@gblaih gblaih mentioned this pull request Jul 20, 2023
Merged
@dippindots dippindots force-pushed the two-sided-fisher-test branch from fae6d16 to 0425e7b Compare August 1, 2023 04:30
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dippindots dippindots merged commit 70f4597 into cBioPortal:master Aug 1, 2023
@dippindots dippindots mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dippindots dippindots dippindots approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change 1-sided fisher exact test to two-sided
2 participants
@gblaih @dippindots