Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the risk of actions getting replayed in FixedUpdate #616

Open
cBournhonesque opened this issue Aug 31, 2024 · 2 comments
Open

Document the risk of actions getting replayed in FixedUpdate #616

cBournhonesque opened this issue Aug 31, 2024 · 2 comments

Comments

@cBournhonesque
Copy link
Owner

If we have a system in FixedUpdate that calls `buffer_message_to_send, then during each rollback the system would get called multiple times again, which means the message would be sent multiple times.

Maybe we should provide a schedule FixedUpdateWithoutRollback for actions that should happen in FixedUpdate but shouldn't be rolled back?

@msvbg
Copy link
Contributor

msvbg commented Aug 31, 2024

I don't think more schedules should be added, since there's already a lot of schedules in Bevy and adding more is both confusing and reduces available parallelism. Maybe buffer_message_to_send could detect that Lightyear is in rollback and no-op automatically, returning an error value.

@cBournhonesque
Copy link
Owner Author

That's a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants