Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder PM null check #91

Merged
merged 1 commit into from
May 26, 2022
Merged

Reorder PM null check #91

merged 1 commit into from
May 26, 2022

Conversation

dchiquito
Copy link
Contributor

The previous ordering would cause a null access exception when checking pmInstance.joined even if the null check
was triggered.

Fixes #90

@dchiquito
Reorder PM null check
e587064 
The previous ordering would cause an exception even if the null check
was triggered.
@dchiquito dchiquito marked this pull request as ready for review May 26, 2022 17:05
@cblgh
Copy link
Member

cblgh commented May 26, 2022

ahhh, thanks!

@cblgh cblgh merged commit 5197b59 into cabal-club:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE when starting a new private message conversation
2 participants
@dchiquito @cblgh