add preferredPort (default 13331) to core opts #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a preferredPort to listen for hyperswarm connections on. the preferredPort is smart enough that if it is blocked, hyperswarm will try preferredPort+1, preferredPort+2 before giving up. see the hyperswarm code: https://github.com/hyperswarm/network/blob/ad41b0c2ac19dbf92865e481282ba6ac6e513d57/index.js#L150-L162 this allows people with highly configured firewalls to port forward a single port for cabal, which they can themselves configure in their clients. fix #98
|
this is what the hyperswarm object looks like when i link this PR to cabal-cli and use it, so i think it works |
|
Thanks @cblgh! This makes it a lot easier for people with server space to support the project. I'll test out when I have some free time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a preferredPort to listen for hyperswarm connections on. the
preferredPort is smart enough that if it is blocked, hyperswarm will try
preferredPort+1, preferredPort+2 before giving up. see the hyperswarm code:
https://github.com/hyperswarm/network/blob/ad41b0c2ac19dbf92865e481282ba6ac6e513d57/index.js#L150-L162
this allows people with highly configured firewalls to port forward a
single port for cabal, which they can themselves configure in their
clients.
fix #98