Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core deps & set browser field #104

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Update core deps & set browser field #104

merged 2 commits into from
Apr 27, 2021

Conversation

cblgh
Copy link
Member

@cblgh cblgh commented Apr 11, 2021

HAYOO

This PR sets the browser field of package.json so that we can do some cool hyperswarm-webbing. It also updates a couple of the core dependencies, mimicking the updates needed to make caballo work initially.

With this patch in place, I can successfully browserify cabal-core & query it in the browser (albeit I have only done a couple superficial tests so far, like making sure core.ready fires & executing core.getLocalKey(cb). but it is very very promising :3)

we set the browser field so that we can do some cool hyperswarm-webbing
:3 :3
@cblgh
Copy link
Member Author

cblgh commented Apr 11, 2021

Also obviously a huge amount of kudos to @RangerMauve for hyperswarm-web and random-access-web 🖤

@cblgh
Copy link
Member Author

cblgh commented Apr 11, 2021

might extend this PR as well to take an option to pass onto hyperswarm-web (so that we can send bootstrapping information)

@cblgh
Copy link
Member Author

cblgh commented Apr 25, 2021

ping ping @noffle @substack, i'm gonna merge this within 48h unless there are any objections :)

@hackergrrl
Copy link
Member

hackergrrl commented Apr 25, 2021

@cblgh No objections here, just an FYI that this pulls in hypercore@8, which is not backwards-compatible with the version we have deployed right now on the cabal network (6 I think!). So anyone who uses new client releases /w this PR will be network-partitioned from the current set of users.

I don't think our userbase is large enough that this would cause too much confusion? I'm not really sure. We don't really have a protocol for introducing breaking protocol changes!

@cblgh
Copy link
Member Author

cblgh commented Apr 26, 2021

Thanks for the heads up @noffle, I appreciate your thoughts :)

I was thinking we could maybe make a new major release of cabal-core, cabal-client & the clients once we've gotten cabal-client working nicely in the browser (dunno what's left on that front except to pop it into something like caballo :~~)

In that major bump, I was also considering having private messages implemented in cabal-client & cabal-cli :)

@hackergrrl
Copy link
Member

In that major bump, I was also considering having private messages implemented in cabal-client & cabal-cli :)

That might be a strong argument for folx to upgrade 🔥

@cblgh cblgh merged commit b7e6d7e into master Apr 27, 2021
@cblgh
Copy link
Member Author

cblgh commented Apr 27, 2021

CAST THE ANCHOR ⚓

@cblgh
Copy link
Member Author

cblgh commented Apr 27, 2021

(OR SOMETHING I DONT KNOW IM NOT A SAILOR (YET))

@cblgh cblgh mentioned this pull request Sep 20, 2021
@ralphtheninja ralphtheninja deleted the upgrade-deps branch September 20, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants