-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core deps & set browser field #104
Conversation
we set the browser field so that we can do some cool hyperswarm-webbing :3 :3
Also obviously a huge amount of kudos to @RangerMauve for hyperswarm-web and random-access-web 🖤 |
might extend this PR as well to take an option to pass onto hyperswarm-web (so that we can send bootstrapping information) |
ping ping @noffle @substack, i'm gonna merge this within 48h unless there are any objections :) |
@cblgh No objections here, just an FYI that this pulls in I don't think our userbase is large enough that this would cause too much confusion? I'm not really sure. We don't really have a protocol for introducing breaking protocol changes! |
Thanks for the heads up @noffle, I appreciate your thoughts :) I was thinking we could maybe make a new major release of cabal-core, cabal-client & the clients once we've gotten cabal-client working nicely in the browser (dunno what's left on that front except to pop it into something like caballo :~~) In that major bump, I was also considering having private messages implemented in cabal-client & cabal-cli :) |
That might be a strong argument for folx to upgrade 🔥 |
CAST THE ANCHOR ⚓ |
(OR SOMETHING I DONT KNOW IM NOT A SAILOR (YET)) |
HAYOO
This PR sets the
browser
field ofpackage.json
so that we can do some cool hyperswarm-webbing. It also updates a couple of the core dependencies, mimicking the updates needed to make caballo work initially.With this patch in place, I can successfully browserify cabal-core & query it in the browser (albeit I have only done a couple superficial tests so far, like making sure
core.ready
fires & executingcore.getLocalKey(cb)
. but it is very very promising :3)