Allow messages.read() opts to take priority over defaults #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2018 16:34
Changed the order of the `xtend()` assignment, so that passed opts
takes priority making it possible to override the
`{reverse: true}` with a `false` value instead.
Also added some semi-accurate documentation to that method based on
assumptions.
Made the call to callback unconditional, so that you don't have to wait forever until your callback gets invoked if anything goes wrong. ;)
|
heck yeah for semi-accurate docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the order of the
xtend()assignment, so that passed optstakes priority making it possible to override the
{reverse: true}with afalsevalue instead.Also added some semi-accurate documentation to that method based on
assumptions.