encode now-timestamps properly to avoid overwrites #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What was happening was that when a timestamp, which are monotonic-timestamps, included an e.g. ".001" suffix, it would be considered as "in the future" if the indexer was quick enough to pick it up, and then be converted to "new Date().getTime()". So if two messages were written to a channel fast enough, BOTH would get set to "new Date().getTime()" and the second would overwrite the first in leveldb. This change ensures that proper monotonic-timestamps are used throughout.
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was happening was that when a timestamp, which are
monotonic-timestamps, included an e.g. ".001" suffix, it would be
considered as "in the future" if the indexer was quick enough to pick it
up, and then be converted to "new Date().getTime()". So if two messages
were written to a channel fast enough, BOTH would get set to "new
Date().getTime()" and the second would overwrite the first in leveldb.
This change ensures that proper monotonic-timestamps are used
throughout.