use regex to capture cabal key instead of URL #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently the
new URL()
behaviour is unpredictable. chrome, node, andfirefox all return different values when a cabal key is passed in.
(
searchParams
always seems to work, however)for node the cabal key can be found in
uri.host
, in chromium/electronit's found at
uri.hostname
, for firefox both of those are empty, buturi.pathname
gives the cabal key prepended with two slashes (but thatdoesn't work in node...)
until the IANA change lands / has a standardizing effect, let's just use
a regex to capture it.
this patch also changes
isHypercoreKey
to use the same regex ascabal-client
.i dunno if hypercore has a strict lower-case character requirement, however
fixes #88