Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty arguments list passed to generate/3 in Elixir 1.16 #218

Closed
tomtaylor opened this issue Jan 9, 2024 · 3 comments
Closed

Empty arguments list passed to generate/3 in Elixir 1.16 #218

tomtaylor opened this issue Jan 9, 2024 · 3 comments

Comments

@tomtaylor
Copy link

tomtaylor commented Jan 9, 2024

We're experiencing an issue which emerged when testing an upgrade to Elixir 1.16. The arguments passed to generate/3 in our Nebulex.Caching.KeyGenerator module are now always an empty list. The actual arguments are never included. The first call to the function will fix the return values for all subsequent calls until the cache entry expires.

We're using a decorator in this form:

  @decorate cacheable(
              cache: @cache,
              opts: [ttl: :timer.hours(24)]
            )
  def thing?(a, b)
    ...
  end

I got the current test suite up and running on Elixir 1.16 in #217, so I can see it's not passing, and there's a number of other issues which may or may not be related.

@cabol
Copy link
Owner

cabol commented Jan 9, 2024

Thank you for reporting the issue. I will check it out and fix it ASAP!

@cabol
Copy link
Owner

cabol commented Jan 13, 2024

I pushed a fix to support Elixir 1.16. I will push a new release soon. Please try it out and feel free to reopen the issue in case of a problem.

@cabol cabol closed this as completed Jan 13, 2024
@stocks29
Copy link

Yikes, that's a scary bug. Luckily our project's test suite caught this. I can confirm that the fix in commit 0886eff resolved the issue for us.

When can we expect a new release to hit hex?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants