URL-encode ampersands from webrtc-peer.js, and cleanup disconnected c…

…lients
cacheflowe · Jan 31, 2024 · 1f91177 · 1f91177
1 parent 7f453ee
commit 1f91177
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 10 deletions.
diff --git a/demo/demo--base.js b/demo/demo--base.js
@@ -22,6 +22,7 @@ class DemoBase {
   }
 
   static getDemoId() {
+    document.location.hash = document.location.hash.replace("%26", "&"); // replace url-encoded ampersand
     let id =
       document.location.hash.indexOf("&") == -1
         ? document.location.hash

diff --git a/demo/demo-webrtc-group-game.js b/demo/demo-webrtc-group-game.js
@@ -173,6 +173,15 @@ class WebRtcGroupGameDemo extends DemoBase {
         </div>
       `;
     });
+    this.kiosk.addListener("peerConnected", (data) => {
+      console.log("peerConnected", data);
+    });
+    this.kiosk.addListener("clientConnected", (data) => {
+      console.log("clientConnected", data);
+    });
+    this.kiosk.addListener("peerClose", (data) => {
+      console.log("peerClose", data);
+    });
   }
 
   buildClientUI() {

diff --git a/src/webrtc-peer.js b/src/webrtc-peer.js
@@ -343,7 +343,8 @@ class WebRtcKiosk extends WebRtcPeer {
     // build URL for client connection
     let url = window.location.href;
     if (replaceFunction) url = replaceFunction(url);
-    let separator = url.indexOf("#") == -1 ? "#" : "&";
+    let separator = url.indexOf("#") == -1 ? "#" : "%26";
+    urlParams = urlParams.replace("&", "%26");
     let connectionURL = `${url}${separator}offer=${this.peerID}${urlParams}`;
 
     // add link container if it doesn't exist
@@ -381,7 +382,9 @@ class WebRtcKiosk extends WebRtcPeer {
 
   connectionIsGood(conn) {
     return (
-      conn.open && Date.now() - conn.connectTime < this.maxClientConnectionTime
+      conn.open &&
+      conn.peerConnection.connectionState == "connected" &&
+      Date.now() - conn.connectTime < this.maxClientConnectionTime
     );
   }
 
@@ -394,19 +397,18 @@ class WebRtcKiosk extends WebRtcPeer {
     // remove any connections that have been closed
     let removedAny = false;
     this.connections.forEach((conn, i) => {
-      // if (this.connectionIsGood(conn) == false) {
-      //   this.removeConnectionListeners(conn);
-      //   if (conn.call) this.removeCallListeners(conn.call);
-      //   conn.close();
-      //   removedAny = true;
-      // }
+      if (this.connectionIsGood(conn) == false) {
+        this.removeConnectionListeners(conn);
+        if (conn.call) this.removeCallListeners(conn.call);
+        conn.close();
+        removedAny = true;
+      }
     });
+    console.log(removedAny);
     // filter old connections from array
-    // if (removedAny) {
     this.connections = this.connections.filter((conn) => {
       return this.connectionIsGood(conn);
     });
-    // }
     this.emit("connections", this.connections);
   }