Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show spending breakdown by committee in descending order (high to low) #332

Open
sfdoran opened this issue Oct 19, 2018 · 3 comments
Open

Comments

@sfdoran
Copy link

sfdoran commented Oct 19, 2018

Expenditures to support and oppose ballot measures are listed in alpha order by committee name. Let's list them high to low for consistency.

image

@ckingbailey
Copy link
Collaborator

@tdooner This seems easier to solve on the backend than in Jekyll

@r-i-c-h
Copy link
Contributor

r-i-c-h commented Oct 24, 2018

(Sorry, was also looking into this)
Recommend a filter/unique check for id on backend or in build on rendering of data.

Issue cause: "duplicate" id in data.

The supporting var in/odca-jekyll/_layouts/referendum.html is pulled from
/OpenOaklandJekyllSite/odca-jekyll/_data/referendum_supporting/oakland/2018-11-06/hotel-employee-minimum-wage-and-workplace-protections.json

In that json file, you can see the same id doubled:


"supporting_organizations": [
    {
      "id": "1405491", // <~~~~~~~
      "name": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "payee": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "amount": 54395.88
    },
    {
      "id": "1405491", // <~~~~~~~
      "name": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "payee": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "amount": 85124.53
    }

There is a note in odca-jekyll/_includes/supporting_opposing_committees.html by @adborden :

We're dealing with two different object shapes, a committee from collection, or
  a committee from the referendum supporting/opposing organzation list. One has
  `filer_id`, the other `id`.

@mikeubell
Copy link
Collaborator

(Sorry, was also looking into this) Recommend a filter/unique check for id on backend or in build on rendering of data.

Issue cause: "duplicate" id in data.

The supporting var in/odca-jekyll/_layouts/referendum.html is pulled from /OpenOaklandJekyllSite/odca-jekyll/_data/referendum_supporting/oakland/2018-11-06/hotel-employee-minimum-wage-and-workplace-protections.json

In that json file, you can see the same id doubled:


"supporting_organizations": [
    {
      "id": "1405491", // <~~~~~~~
      "name": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "payee": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "amount": 54395.88
    },
    {
      "id": "1405491", // <~~~~~~~
      "name": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "payee": "East Bay Alliance for a Sustainable Economy (EBASE) nonprofit 501(c)(3)",
      "amount": 85124.53
    }

There is a note in odca-jekyll/_includes/supporting_opposing_committees.html by @adborden :

We're dealing with two different object shapes, a committee from collection, or
  a committee from the referendum supporting/opposing organzation list. One has
  `filer_id`, the other `id`.

This seems to be a different issue. I'm guessing that the committee was involved in multiple elections. The duplication problem is probably fixed with our Start/End date columns in the committee sheet.

@mikeubell mikeubell transferred this issue from caciviclab/odca-jekyll Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants