Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic-go v0.35.0 #5559

Closed
bt90 opened this issue May 30, 2023 · 5 comments · Fixed by #5560
Closed

quic-go v0.35.0 #5559

bt90 opened this issue May 30, 2023 · 5 comments · Fixed by #5560
Labels
dependencies ⛓️ Pull requests that update a dependency file

Comments

@bt90
Copy link
Contributor

bt90 commented May 30, 2023

https://github.com/quic-go/quic-go/releases/tag/v0.35.0

quic-go/quic-go#3795 allows for a solid bump in HTTP/3 performance without having to deal with sysctl limits.

@francislavoie
Copy link
Member

Yep! We have notifications for releases enabled too 😅

This one is a tricky upgrade unfortunately... we were relying on quic.EarlyListener being an interface to wrap it into a fakeCloseQuicListener so that we could reuse the listener across config reloads. Now that it's a struct though, the Go compiler isn't happy with us. We'll probably need to rewrite some things. 😢 /cc @marten-seemann

@francislavoie francislavoie added the dependencies ⛓️ Pull requests that update a dependency file label May 30, 2023
@marten-seemann
Copy link
Contributor

I already have a patch for you in the works :) Will send a PR soon.

@francislavoie
Copy link
Member

Oh nice, that was much simpler than I thought. Didn't know that type existed! Thanks!

@otbutz
Copy link

otbutz commented May 30, 2023

We also need to adjust our service definitions if we want to profit from quic-go/quic-go#3795

caddyserver/dist#97

@mholt
Copy link
Member

mholt commented May 30, 2023

Ah, thank you everyone for this enhancement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ⛓️ Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants