Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace graceful restart code for binary upgrades (SIGUSR2) #814

Closed
mholt opened this issue May 10, 2016 · 0 comments · Fixed by #1814
Closed

Replace graceful restart code for binary upgrades (SIGUSR2) #814

mholt opened this issue May 10, 2016 · 0 comments · Fixed by #1814
Labels
feature ⚙️ New feature or request
Milestone

Comments

@mholt
Copy link
Member

mholt commented May 10, 2016

In #807 @tpng did the excellent thing of making all reloads, even graceful ones, happen within the same process. It deleted a lot of code and made Caddy much better.

However, now it is impossible, I think, to upgrade the Caddy binary gracefully. Where before a new caddy process would be executed, thus allowing the sysadmin to replace the old caddy binary with a new one, now that no longer happens. So you have to stop and restart the process to upgrade the server.

I propose we introduce the USR2 signal for graceful upgrades. This essentially restarts the process gracefully like we did before, except that we do not load a new Caddyfile; instead we pass in the current Caddyfile via gob.

Let's not begin work on this until I push my 0.9 progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant