Fix go-generate calling, do more before running tests #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does a couple things: - `make generate` now infers files that might affect generation. This should work as long as we keep simple codegen (the server has moved beyond this, sadly). - `make generate` now forces re-generation regardless of need, because it's a nice workaround for dependency issues like happened in cadence-workflow#1373 - `make test` and related targets now go-generate and fmt before running tests. Slower, but you can't forget to re-generate, and they're slow already so it's probably fine.
Groxx
requested review from
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Groxx
commented
Nov 1, 2024
| @@ -27,6 +27,8 @@ import ( | |||
| "go.uber.org/cadence/internal/common/util" | |||
| ) | |||
|
|
|||
| //go:generate mockery --name Value --output ../mocks --boilerplate-file ../LICENSE | |||
There was a problem hiding this comment.
I moved these so they're in the file with the thing they define (so the dependency setup is trivial), and because it's simpler: no need to specify the internal-package bit.
code generation after this is identical.
3vilhamster
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a couple things:
make $(BUILD)/generatenow infers files that might affect generation. This should work as long as we keep simple codegen (the server has moved beyond this, sadly).make generatenow forces re-generation regardless of need, because it's a nice workaround for dependency issues like happened in [internal] Improve code coverage of internal_task_pollers.go #1373make testand related targets now go-generate and fmt before running tests. Slower, but you can't forget to re-generate, and they're slow already so it's probably fine.