Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect nil handling in workflowTaskPoller #1412

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

shijiesheng
Copy link
Member

@shijiesheng shijiesheng commented Dec 11, 2024

What changed?

  • explicit nil handling in newWorkflowTaskPoller for ldaTunnel

Why?

Golang doesn't handle passing in nil pointer of concrete type directly into the interface. It still considers it not nil, which will cause panic in this case.

How did you test it?

Unit test fail before and pass after the change

Potential risks

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.59%. Comparing base (9ffbb1f) to head (ffe6726).
Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/internal_task_pollers.go 82.76% <100.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffbb1f...ffe6726. Read the comment docs.

@shijiesheng shijiesheng merged commit 2bceb13 into cadence-workflow:master Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants