-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jackson DataConverter #401
Comments
Would like to +1 this as Jackson has built in support for Java 8 Time objects allowing you to send your java.time.Instant or java.time.ZonedDateTime as a string. |
Would be a good thing indeed to be adding, especially when one day we want to be able to provide a Spring Boot starter for Cadence. +1 |
I suggest testing all changes done for this issue on both JDK 8 and JDK 13 so that both the current supported Java LTS version and the latest Java version have been covered. To reach this goal, I will be making a separate Docker and Docker-compose file that make this possible. |
Should we use Multi-Release Jars to support multiple Java versions? |
I think it would be a nice touch, however, I don't think it's something really for the Cadence Client, as it would require a lot more change and a lot more complications in the development cycle to implement this feature to it's fullest (versus having multiple builds of the client). When it comes to testing, I don't think that using it for the client, which is "bound" to a specific version, makes it easier to maintain the code. We will need to also maintain the tests which might have dependencies which are bound to a specific version, limiting us into even using these Java features. For example, we maybe want to use a new Java 13 feature but in order to test it, we might have to completely build a specific part of a testing framework our selves as these do not support these Java 13 features yet. I do rather have it to support from a specific LTS version and to have sub-versions of the Cadence Java Client on other non-main (as in non-main Cadence supported) Java versions (kind of like development/POC versions of the Java client). I would suggest to instead of having the Multi-Release Jars, to support up to Java 11 (LTS) and to have versions that support certain features from Java 12, 13, etc. |
Consider switching the default data converter to Jackson.
The text was updated successfully, but these errors were encountered: