Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up linting warnings #4290

Merged
merged 10 commits into from
Jul 7, 2021
Merged

Clean up linting warnings #4290

merged 10 commits into from
Jul 7, 2021

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jul 2, 2021

What changed?
Clean up linting warnings

This is the part 1. Peresistence fold linting is pending after the nosql refactoring is done.

Why?
Too many linting warnings

How did you test it?
N/A

Potential risks
N/A

Release notes
N/A

Documentation Changes

@yux0 yux0 requested a review from a team July 2, 2021 00:04
@coveralls
Copy link

coveralls commented Jul 2, 2021

Pull Request Test Coverage Report for Build ebf64511-869e-423f-a12d-8fa53ecfb1ee

  • 61 of 71 (85.92%) changed or added relevant lines in 18 files are covered.
  • 46 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-3.4%) to 56.735%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosqlTaskStore.go 0 1 0.0%
service/worker/scanner/workflow.go 1 2 50.0%
common/persistence/sql/sqlplugin/postgres/db.go 1 3 33.33%
common/persistence/visibilitySamplingClient.go 0 2 0.0%
common/util.go 4 6 66.67%
tools/cli/adminCommands.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
service/history/execution/mutable_state_builder.go 2 69.87%
service/history/queue/timer_queue_processor.go 2 58.77%
common/cache/lru.go 3 90.73%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/execution/context.go 6 68.39%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 15 58.53%
Totals Coverage Status
Change from base Build b95471af-bfe2-40b6-92e0-02a9af723f67: -3.4%
Covered Lines: 77556
Relevant Lines: 136699

💛 - Coveralls

host/client_integration_test.go Outdated Show resolved Hide resolved
host/ndc/integration_test.go Show resolved Hide resolved
// this struct is more like a union and only one of [ query, event, forwarded ] is
// non-nil for any given task
internalTask struct {
InternalTask struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand why we need to export this type. Looks like an internal type definition for matching package to me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Other components in matching are already exported so I make this struct exported as well. My plan is to do a refactor in matching (similar to the history, to group the components in sub packages and export them)

@yux0 yux0 merged commit 24cd8fa into cadence-workflow:master Jul 7, 2021
@yux0 yux0 deleted the cleanup-lint branch July 7, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants