-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up linting warnings #4290
Conversation
// this struct is more like a union and only one of [ query, event, forwarded ] is | ||
// non-nil for any given task | ||
internalTask struct { | ||
InternalTask struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand why we need to export this type. Looks like an internal type definition for matching package to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Other components in matching are already exported so I make this struct exported as well. My plan is to do a refactor in matching (similar to the history, to group the components in sub packages and export them)
What changed?
Clean up linting warnings
This is the part 1. Peresistence fold linting is pending after the nosql refactoring is done.
Why?
Too many linting warnings
How did you test it?
N/A
Potential risks
N/A
Release notes
N/A
Documentation Changes