Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definition for cross-cluster related endpoints #4294

Merged
merged 4 commits into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
441 changes: 430 additions & 11 deletions .gen/go/shared/shared.go

Large diffs are not rendered by default.

424 changes: 279 additions & 145 deletions .gen/proto/admin/v1/service.pb.go

Large diffs are not rendered by default.

441 changes: 226 additions & 215 deletions .gen/proto/admin/v1/service.pb.yarpc.go

Large diffs are not rendered by default.

747 changes: 462 additions & 285 deletions .gen/proto/history/v1/service.pb.go

Large diffs are not rendered by default.

726 changes: 369 additions & 357 deletions .gen/proto/history/v1/service.pb.yarpc.go

Large diffs are not rendered by default.

216 changes: 132 additions & 84 deletions .gen/proto/shared/v1/queue.pb.go

Large diffs are not rendered by default.

151 changes: 79 additions & 72 deletions .gen/proto/shared/v1/queue.pb.yarpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions common/types/mapper/proto/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,8 @@ func FromAdminGetCrossClusterTasksResponse(t *types.GetCrossClusterTasksResponse
return nil
}
return &adminv1.GetCrossClusterTasksResponse{
TasksByShard: FromCrossClusterTaskRequestMap(t.TasksByShard),
TasksByShard: FromCrossClusterTaskRequestMap(t.TasksByShard),
FailedCauseByShard: FromGetTaskFailedCauseMap(t.FailedCauseByShard),
}
}

Expand All @@ -715,6 +716,7 @@ func ToAdminGetCrossClusterTasksResponse(t *adminv1.GetCrossClusterTasksResponse
return nil
}
return &types.GetCrossClusterTasksResponse{
TasksByShard: ToCrossClusterTaskRequestMap(t.TasksByShard),
TasksByShard: ToCrossClusterTaskRequestMap(t.TasksByShard),
FailedCauseByShard: ToGetTaskFailedCauseMap(t.FailedCauseByShard),
}
}
8 changes: 6 additions & 2 deletions common/types/mapper/proto/history.go
Original file line number Diff line number Diff line change
Expand Up @@ -1419,7 +1419,8 @@ func FromHistoryGetCrossClusterTasksResponse(t *types.GetCrossClusterTasksRespon
return nil
}
return &historyv1.GetCrossClusterTasksResponse{
TasksByShard: FromCrossClusterTaskRequestMap(t.TasksByShard),
TasksByShard: FromCrossClusterTaskRequestMap(t.TasksByShard),
FailedCauseByShard: FromGetTaskFailedCauseMap(t.FailedCauseByShard),
}
}

Expand All @@ -1429,7 +1430,8 @@ func ToHistoryGetCrossClusterTasksResponse(t *historyv1.GetCrossClusterTasksResp
return nil
}
return &types.GetCrossClusterTasksResponse{
TasksByShard: ToCrossClusterTaskRequestMap(t.TasksByShard),
TasksByShard: ToCrossClusterTaskRequestMap(t.TasksByShard),
FailedCauseByShard: ToGetTaskFailedCauseMap(t.FailedCauseByShard),
}
}

Expand All @@ -1442,6 +1444,7 @@ func FromHistoryRespondCrossClusterTasksCompletedRequest(t *types.RespondCrossCl
ShardId: t.ShardID,
TargetCluster: t.TargetCluster,
TaskResponses: FromCrossClusterTaskResponseArray(t.TaskResponses),
FetchNewTasks: t.FetchNewTasks,
}
}

Expand All @@ -1454,6 +1457,7 @@ func ToHistoryRespondCrossClusterTasksCompletedRequest(t *historyv1.RespondCross
ShardID: t.ShardId,
TargetCluster: t.TargetCluster,
TaskResponses: ToCrossClusterTaskResponseArray(t.TaskResponses),
FetchNewTasks: t.FetchNewTasks,
}
}

Expand Down
Loading