Add X-Cluster Child Workflow Completion Tasks #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demirkayaender
force-pushed
the
recordchild
branch
from
5662806 to
654a8b2
Compare
demirkayaender
commented
Jul 30, 2021
demirkayaender
force-pushed
the
recordchild
branch
2 times, most recently
from
cc5f267 to
4e4d8a9
Compare
demirkayaender
commented
Aug 2, 2021
demirkayaender
commented
Aug 2, 2021
demirkayaender
force-pushed
the
recordchild
branch
from
8f4fd5b to
9b8baf9
Compare
yycptt
reviewed
Aug 11, 2021
demirkayaender
force-pushed
the
recordchild
branch
from
ac710b7 to
2267a72
Compare
yycptt
reviewed
Aug 16, 2021
| // TODO: pass crossClusterTaskGenerators to processParentClosePolicy to add new cross | ||
| // cluster tasks then move the call below after processParentClosePolicy call | ||
| if len(crossClusterTaskGenerators) > 0 { | ||
| t.generateCrossClusterTasks( |
There was a problem hiding this comment.
handle the returned error?
and the call should always be after processParentClosePolicy I think, regardless of whether processParentClosePolicy creates an x-cluster task or not?
There was a problem hiding this comment.
Added the error handling.
I was planning move this down after the parent close policy changes. Could be better to keep the changes smaller and for one API. In the PR after this one it will be after the processParentClosePolicy.
demirkayaender
force-pushed
the
recordchild
branch
from
4baa4aa to
ee48929
Compare
yycptt
approved these changes
Aug 18, 2021
demirkayaender
force-pushed
the
recordchild
branch
from
ee48929 to
8e7c80f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Defining and persisting cross cluster tasks for RecordChildWorkflowExeuctionComplete task.
Why?
With this diff, child workflow notify the remote workflow about its completion.
How did you test it?
transfer_active_task_executor_test
Potential risks
Release notes
Documentation Changes