Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contributing and dev process #4347

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Aug 10, 2021

What changed?

  1. Use docker compose for all dependencies
  2. Update Contributing guide

Why?
The original way of running local Cassandra is very tedious. And after upgrading to Java 9, local Cassandra is mostly broken. See https://stackoverflow.com/questions/48844252/cassandra-start-error-with-threadprioritypolicy-42
The best/stable way to run Cassandra is docker compose.

How did you test it?
Local tested the whole process

Potential risks
No

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Aug 10, 2021

Pull Request Test Coverage Report for Build 1da67f46-0847-4bdd-8859-929b465aa817

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 56.853%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 74.4%
common/task/fifoTaskScheduler.go 2 87.63%
service/matching/taskListManager.go 2 74.09%
service/history/queue/timer_queue_processor_base.go 4 78.78%
common/persistence/nosql/nosqlExecutionStore.go 9 57.52%
Totals Coverage Status
Change from base Build 45ffe188-c9b2-42ba-bd88-da4a31e817a0: 0.04%
Covered Lines: 78076
Relevant Lines: 137329

💛 - Coveralls

@github-actions github-actions bot force-pushed the qlong-contributing branch from da1040c to a61eee1 Compare August 10, 2021 19:20
@longquanzheng longquanzheng changed the title [WIP] Improve contributing and dev process Improve contributing and dev process Aug 10, 2021
@longquanzheng longquanzheng marked this pull request as ready for review August 10, 2021 19:21
@longquanzheng longquanzheng requested review from yux0, yycptt and Groxx August 10, 2021 19:23
@longquanzheng longquanzheng merged commit 7420786 into master Aug 10, 2021
@longquanzheng longquanzheng deleted the qlong-contributing branch August 10, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants