Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically adjust task priority and redispatch interval based on attempts #4378

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Aug 17, 2021

What changed?

  • Automatically adjust task priority to low when task is keep retrying
  • Assign different redispatch backoff interval for different tasks based on number of attempts

Why?

  • Reducing the impact of tasks that are keep retrying.

How did you test it?

  • Unit test

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and a team August 17, 2021 17:14
@coveralls
Copy link

coveralls commented Aug 17, 2021

Pull Request Test Coverage Report for Build 2e281532-0ce9-419a-b13e-695201ef3d55

  • 83 of 88 (94.32%) changed or added relevant lines in 8 files are covered.
  • 38 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.06%) to 56.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/redispatcher.go 47 52 90.38%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 41.25%
client/history/metricClient.go 2 47.05%
common/membership/rpServiceResolver.go 2 73.58%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/handler.go 2 48.15%
service/history/task/redispatcher.go 2 89.67%
common/cache/lru.go 3 90.73%
common/persistence/dataManagerInterfaces.go 3 62.54%
service/frontend/workflowHandler.go 4 58.8%
Totals Coverage Status
Change from base Build 25aa045b-af2b-4934-a836-df202095baa5: 0.06%
Covered Lines: 79034
Relevant Lines: 139846

💛 - Coveralls

@demirkayaender demirkayaender requested a review from a team August 24, 2021 21:25
@yycptt yycptt force-pushed the auto-adjust-task-priority branch from 01f5fd8 to b7ff716 Compare August 25, 2021 20:24
@yycptt yycptt merged commit fb10abe into cadence-workflow:master Aug 25, 2021
@yycptt yycptt deleted the auto-adjust-task-priority branch August 25, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants