Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.7 compatibility #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Django 1.7 compatibility #78

wants to merge 2 commits into from

Conversation

antonagestam
Copy link

fixes #77

Replaced django.http.HttpResponse with django.http.JsonResponse with fallback for Django < 1.7.

@sigvef
Copy link

sigvef commented May 12, 2014

#77 probably affects other parts of the code base as well (e.g. views.py#L301 ), consider moving the JsonResponse shim to a separate file so it can be reused everywhere it is needed.

(I was sent here to review this pull request by http://www.codevolley.com/ , please ignore my comments if they are out of place :) )

@luto
Copy link

luto commented Jul 2, 2014

any news on this? :)

@antonagestam
Copy link
Author

@luto I bumped into a lot of problems with migrations in 1.7, so downgraded to 1.6 again. I might spend time on this again once 1.7 is released.

@beaugunderson
Copy link

@sigvef The current PR addresses views.py#L301 and I can't find another affected place in the codebase. It also works well for me. 👍 for merging it as 1.7 is now final. :)

I have a fix for test.sh that will be needed for 1.7 as well and will make a PR for that soon but this should get in ASAP.

@beaugunderson
Copy link

OK, my PR that fixes tests is ready in #102.

I also ran all of the tests on Django 1.4, 1.5, 1.6, and 1.7 with this pull request applied and they passed cleanly. A merge of #102 and this would be greatly appreciated by those of us using 1.7 now. ✨

@@ -9,6 +8,14 @@
from . import constants, scope


try:
from django.http import JsonResponse
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, I would add since >= django1.7 comment and maybe move that to provider/compat ?

@egamonal
Copy link

Hi, has this been abandoned? looks like this PR is still open

@antonagestam
Copy link
Author

@egamonal I think https://github.com/idan/oauthlib is a safer bet these days :)

@egamonal
Copy link

thanks @antonagestam , I was trying django-oauth-toolkit to get ready for updating django rest framework to 3.x . I'll give that one a shot as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__init__() got an unexpected keyword argument 'mimetype'
6 participants