From 251cd5d1ab770f86c89ce13999d56f3c06e3ef1d Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 15:18:57 -0500 Subject: [PATCH 1/7] Use node20 as node16 is deprecated --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index cba3514..f374291 100755 --- a/action.yml +++ b/action.yml @@ -36,7 +36,7 @@ outputs: jira-issue-source: description: 'Indication how the jira issue was found, by - branch | pr-title | null' runs: - using: 'node16' + using: 'node20' main: 'lib/index.js' branding: icon: 'terminal' From 1f4aa84c5ee15e0fb19037d4eea63f1e94b6d527 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 15:19:54 -0500 Subject: [PATCH 2/7] Update .nvmrc with Node v20 --- .nvmrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.nvmrc b/.nvmrc index b6a7d89..209e3ef 100755 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16 +20 From 89affab2c85580dc4aafc3a0a1b262fad27cfd12 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 15:22:41 -0500 Subject: [PATCH 3/7] Update pr-test with latest versions These version updates are also for using current Node version (20). No need to do manual cache with newer setup-node versions as caching is now built in. --- .github/workflows/pr-test.yml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr-test.yml b/.github/workflows/pr-test.yml index 58590c2..1bd9930 100755 --- a/.github/workflows/pr-test.yml +++ b/.github/workflows/pr-test.yml @@ -6,23 +6,11 @@ jobs: build-test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v3 - name: setup node + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - - - name: Cache node modules - uses: actions/cache@v2 - env: - cache-name: cache-node-modules - with: - path: node_modules - key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }} - restore-keys: | - ${{ runner.os }}-build-${{ env.cache-name }}- - ${{ runner.os }}-build- - ${{ runner.os }}- + cache: npm - name: "install" run: npm ci --production From 24b75ccc6af1bdd2b2f034403d7349c337392a5e Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 15:24:23 -0500 Subject: [PATCH 4/7] Update pr-branch-checks with latest versions These version updates are also for using current Node version (20). No need to do manual cache with newer setup-node versions as caching is now built in. --- .github/workflows/pr-branch-checks.yml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr-branch-checks.yml b/.github/workflows/pr-branch-checks.yml index 6e05610..b0abe96 100755 --- a/.github/workflows/pr-branch-checks.yml +++ b/.github/workflows/pr-branch-checks.yml @@ -11,23 +11,11 @@ jobs: build-test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v3 - name: setup node + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - - - name: Cache node modules - uses: actions/cache@v2 - env: - cache-name: cache-node-modules - with: - path: node_modules - key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }} - restore-keys: | - ${{ runner.os }}-build-${{ env.cache-name }}- - ${{ runner.os }}-build- - ${{ runner.os }}- + cache: npm - name: "install" run: npm ci --production From 0cafd4427d0fe985f7fe380003ff99b4651ff2aa Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 17:44:04 -0500 Subject: [PATCH 5/7] Bump versions in engines --- package-lock.json | 4 ++-- package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 645742d..8cd6fa5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -31,8 +31,8 @@ "prettier": "^2.1.2" }, "engines": { - "node": ">= 16", - "npm": ">= 8" + "node": ">= 20", + "npm": ">= 10" } }, "node_modules/@actions/core": { diff --git a/package.json b/package.json index dda5115..3af10b8 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,8 @@ "url": "git+https://github.com/cakeinpanic/jira-description-action" }, "engines": { - "node": ">= 16", - "npm": ">= 8" + "node": ">= 20", + "npm": ">= 10" }, "keywords": [ "actions", From 68520c3ce7156e56c30e6ac4bfd768e2dae85740 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 17:49:57 -0500 Subject: [PATCH 6/7] Fix ncc deprecation warning > npm WARN deprecated @zeit/ncc@0.22.3: @zeit/ncc is no longer maintained. Please use @vercel/ncc instead. --- package-lock.json | 19 +++++++++---------- package.json | 2 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8cd6fa5..d99d1f1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15,7 +15,7 @@ "@octokit/webhooks-definitions": "^3.67.3", "@types/jest": "^25.2.3", "@types/node": "^13.13.30", - "@zeit/ncc": "^0.22.3", + "@vercel/ncc": "^0.38.1", "axios": "^0.19.2", "engines-ok": "^1.2.0", "jest": "^25.5.4", @@ -1599,11 +1599,10 @@ "resolved": "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-15.0.0.tgz", "integrity": "sha512-FA/BWv8t8ZWJ+gEOnLLd8ygxH/2UFbAvgEonyfN6yWGLKc7zVjbpl2Y4CTjid9h2RfgPP6SEt6uHwEOply00yw==" }, - "node_modules/@zeit/ncc": { - "version": "0.22.3", - "resolved": "https://registry.npmjs.org/@zeit/ncc/-/ncc-0.22.3.tgz", - "integrity": "sha512-jnCLpLXWuw/PAiJiVbLjA8WBC0IJQbFeUwF4I9M+23MvIxTxk5pD4Q8byQBSPmHQjz5aBoA7AKAElQxMpjrCLQ==", - "deprecated": "@zeit/ncc is no longer maintained. Please use @vercel/ncc instead.", + "node_modules/@vercel/ncc": { + "version": "0.38.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.38.1.tgz", + "integrity": "sha512-IBBb+iI2NLu4VQn3Vwldyi2QwaXt5+hTyh58ggAMoCGE6DJmPvwL3KPBWcJl1m9LYPChBLE980Jw+CS4Wokqxw==", "bin": { "ncc": "dist/ncc/cli.js" } @@ -15043,10 +15042,10 @@ "resolved": "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-15.0.0.tgz", "integrity": "sha512-FA/BWv8t8ZWJ+gEOnLLd8ygxH/2UFbAvgEonyfN6yWGLKc7zVjbpl2Y4CTjid9h2RfgPP6SEt6uHwEOply00yw==" }, - "@zeit/ncc": { - "version": "0.22.3", - "resolved": "https://registry.npmjs.org/@zeit/ncc/-/ncc-0.22.3.tgz", - "integrity": "sha512-jnCLpLXWuw/PAiJiVbLjA8WBC0IJQbFeUwF4I9M+23MvIxTxk5pD4Q8byQBSPmHQjz5aBoA7AKAElQxMpjrCLQ==" + "@vercel/ncc": { + "version": "0.38.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.38.1.tgz", + "integrity": "sha512-IBBb+iI2NLu4VQn3Vwldyi2QwaXt5+hTyh58ggAMoCGE6DJmPvwL3KPBWcJl1m9LYPChBLE980Jw+CS4Wokqxw==" }, "abab": { "version": "2.0.5", diff --git a/package.json b/package.json index 3af10b8..8049636 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "@octokit/webhooks-definitions": "^3.67.3", "@types/jest": "^25.2.3", "@types/node": "^13.13.30", - "@zeit/ncc": "^0.22.3", + "@vercel/ncc": "^0.38.1", "axios": "^0.19.2", "engines-ok": "^1.2.0", "jest": "^25.5.4", From 1536f06186803e5efdd077681117645940c8252f Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Wed, 28 Feb 2024 17:58:04 -0500 Subject: [PATCH 7/7] Remove unused @octokit/webhooks-definitions This doesn't seem to be used as I see no reference anywhere in source other than the package.json file: https://github.com/search?q=repo%3Acakeinpanic%2Fjira-description-action%20webhook&type=code This package reports a deprecation warning on npm install in CI: > npm WARN deprecated @octokit/webhooks-definitions@3.67.3: Use @octokit/webhooks-types, @octokit/webhooks-schemas, or @octokit/webhooks-examples instead. See https://github.com/octokit/webhooks/issues/447 Instead of using one of the packages I figure it was safest and easiest to just remove it if its unused which seems to be the case from what I can tell. --- package-lock.json | 12 ------------ package.json | 1 - 2 files changed, 13 deletions(-) diff --git a/package-lock.json b/package-lock.json index d99d1f1..b84d5a2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,6 @@ "@actions/core": "^1.10.1", "@actions/github": "^5.1.1", "@octokit/rest": "^20.0.1", - "@octokit/webhooks-definitions": "^3.67.3", "@types/jest": "^25.2.3", "@types/node": "^13.13.30", "@vercel/ncc": "^0.38.1", @@ -1357,12 +1356,6 @@ "@octokit/openapi-types": "^12.11.0" } }, - "node_modules/@octokit/webhooks-definitions": { - "version": "3.67.3", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-definitions/-/webhooks-definitions-3.67.3.tgz", - "integrity": "sha512-do4Z1r2OVhuI0ihJhQ8Hg+yPWnBYEBNuFNCrvtPKoYT1w81jD7pBXgGe86lYuuNirkDHb0Nxt+zt4O5GiFJfgA==", - "deprecated": "Use @octokit/webhooks-types, @octokit/webhooks-schemas, or @octokit/webhooks-examples instead. See https://github.com/octokit/webhooks/issues/447" - }, "node_modules/@pnpm/config.env-replace": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/@pnpm/config.env-replace/-/config.env-replace-1.1.0.tgz", @@ -14830,11 +14823,6 @@ "@octokit/openapi-types": "^12.11.0" } }, - "@octokit/webhooks-definitions": { - "version": "3.67.3", - "resolved": "https://registry.npmjs.org/@octokit/webhooks-definitions/-/webhooks-definitions-3.67.3.tgz", - "integrity": "sha512-do4Z1r2OVhuI0ihJhQ8Hg+yPWnBYEBNuFNCrvtPKoYT1w81jD7pBXgGe86lYuuNirkDHb0Nxt+zt4O5GiFJfgA==" - }, "@pnpm/config.env-replace": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/@pnpm/config.env-replace/-/config.env-replace-1.1.0.tgz", diff --git a/package.json b/package.json index 8049636..eeff76b 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,6 @@ "@actions/core": "^1.10.1", "@actions/github": "^5.1.1", "@octokit/rest": "^20.0.1", - "@octokit/webhooks-definitions": "^3.67.3", "@types/jest": "^25.2.3", "@types/node": "^13.13.30", "@vercel/ncc": "^0.38.1",