Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binaryuuid type support to sql server #1746

Closed
MasterOdin opened this issue Apr 11, 2020 · 2 comments · Fixed by #1826
Closed

Add binaryuuid type support to sql server #1746

MasterOdin opened this issue Apr 11, 2020 · 2 comments · Fixed by #1826

Comments

@MasterOdin
Copy link
Member

From #1734 (comment), #1734 (comment)

For SQLServer, binaryuuid would probably map to the same type as static::PHINX_TYPE_UUID, namely uniqueidentifier, though like the postgresql adapter, you would not be able to do a comparison against static::PHINX_TYPE_BINARYUUID on saved columns in a table.

The static::PHINX_TYPE_BINARYUUID was added to MySQL, PostgreSQL, and SQLite. Needs to be added to SQL Server, this issue acting as a reminder for that.

@geoidesic
Copy link

So how do we use this for primary key?

@dereuromark
Copy link
Member

dereuromark commented Jul 31, 2020

We should add unit tests for all DBs here that support it to make sure it works for primary keys.
Lets continue discussion in #753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants