-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inv staging deploy #15
Comments
It would be nice to have something better than an AttributeError for this case.
|
Hmm, I disagree with the second part of that. We've always done |
But I also like that command that you showed as an advanced option, in the case that you wanted to rollback a deployment quickly to a recently used tag. Maybe as a |
The rollback option sounds like it could be useful, and I agree that making things easier for the user is desirable. I do think we should put in something that would prevent people from accidentally deploying the wrong code, though (whether on the command line or in the config, etc.). I want to avoid the situation where being on the wrong git branch during a deploy or having uncommitted changes during a deploy means the wrong things get deployed. |
Ahh, that is an excellent point! Then my suggestion would be:
|
That sounds good to me. |
It would be nice to get
inv staging deploy
to be the only command that a dev needs to memorize to do a deploy (similar to how we used to just dofab staging deploy
.Currently
inv staging deploy
does this:Theoretically at least, we could catch that error in
ansible/deploy.py
line 30, and run theimage
task. Thoughts?The text was updated successfully, but these errors were encountered: