-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyterlab: github authenticator #367
Comments
The jupyterhub helm chart will allow for a Github OAuth flow where Cal ITP org users can sign into Cal ITP's JupyterHub by signing in with Github |
TODO: robot user to generate github token for oauth app |
To build on @machow's comment. We need:
Once this is complete, the app's client id and a client secret should be shared with me so I can proceed. |
requesting jupyterhub.calitp.org as the subdomain |
@thekaveman - The application itself only needs to be created in GitHub once. The Github application's Homepage URL and Authorization callback URL can be afterwards as needed. So if we switch to a *.calitp.org domain later on, we should be able to switch the Github application's Homepage URL and Authorization callback URL without an issue. The most important bit is to have a consistent Github application client ID and client secret. |
I registered an org-owned OAuth app under Cal-ITP and sent the details over to @ccjarvus, who has confirmed receipt. |
We have working auth using the org-owned OAuth app. Currently, only users in the Cal-ITP organization can log into Jupyterhub. It would also be possible now to restrict JupyterHub access to specific teams within the Cal-ITP organization. |
Update - we have made it so that only users in the warehouse-users group of the cal-itp org can sign in with Github |
Is your feature request related to a problem? Please describe.
Users should be able to use their github account to login to jupyterlab
Describe the solution you'd like
https://github.com/jupyterhub/oauthenticator
Describe alternatives you've considered
assign usernames / PW manually.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: