Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Account for accessibilityActivationPoint #780

Closed
fabb opened this issue Jun 3, 2015 · 4 comments
Closed

Take Account for accessibilityActivationPoint #780

fabb opened this issue Jun 3, 2015 · 4 comments

Comments

@fabb
Copy link

fabb commented Jun 3, 2015

accessibilityActivationPoint might give a different point than the middle of an element. touch does not take account for that and might miss the clicking area of an element, as it touches in its center.
I'm not sure whether touch should take account for accessibilityActivationPoint or not. What do you think?

@jmoody
Copy link
Contributor

jmoody commented Jun 17, 2015

@fabb This is very interesting. I am not sure what priority to give this. Can you provide a concrete example where the activation point is different from the center? Is the activation point defined on all UIViews? Does it default to the center?

@fabb
Copy link
Author

fabb commented Jun 17, 2015

@jmoody I just learned about it too, as I tried to make our login mask usable for blind people. Our login mask is not table view based, but contains UISwitches with Labels next to it. We have a custom view SwitchWithLabelView for these. For accessibility I made the whole view into an accessibility element by overriding -isAccessibilityElement and returning YES. Apart from overriding -accessibilityLabel, -accessibilityValue and -accessibilityTraits I also had to override -accessibilityActivationPoint as with VoiceOver activated, tapping on the element would not toggle the switch.
Using Calabash for automated UI tests is a bit different from having VoiceOver activated, so I'm also not sure which priority this has. As a workaround for our tests, we adapted the query to press the descendant switch of the given accessibility id for these SwitchWithLabelView elements.

@jmoody
Copy link
Contributor

jmoody commented Sep 2, 2015

The server could be updated to check for the assessibilityActivationPoint rather than or in addition to the view's center.

@jmoody
Copy link
Contributor

jmoody commented Sep 16, 2015

Opened a case on the server. Closing this one.

@jmoody jmoody closed this as completed Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants