Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: settings/my-account - remove pages router and use app router #16793

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 24, 2024

What does this PR do?

  • Fixes CAL-4403
  • remove pages router and use app router for all pages in settings/my-account
  • remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • all settings/my-account/**/* pages must work as expected

Copy link

linear bot commented Sep 24, 2024

@graphite-app graphite-app bot requested a review from a team September 24, 2024 17:54
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Sep 24, 2024 5:55pm
calcom-web-canary ⬜️ Ignored (Inspect) Sep 24, 2024 5:55pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 24, 2024
Copy link

graphite-app bot commented Sep 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as draft September 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables high-risk Requires approval by Foundation team ready-for-e2e 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants