Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional check for oAuth client ID #16809

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cfex
Copy link

@cfex cfex commented Sep 25, 2024

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Sep 25, 2024
@graphite-app graphite-app bot requested a review from a team September 25, 2024 07:08
Copy link

vercel bot commented Sep 25, 2024

@cfex is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Sep 25, 2024
Copy link

graphite-app bot commented Sep 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/25/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/28/24)

1 label was added to this PR based on Keith Williams's automation.

@CarinaWolli CarinaWolli requested a review from a team September 25, 2024 13:47
@anikdhabal anikdhabal added the platform Anything related to our platform plan label Sep 27, 2024
@Ryukemeister Ryukemeister changed the title fix: fix conditional check for oAuth client ID fix: conditional check for oAuth client ID Sep 28, 2024
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working community Created by Linear-GitHub Sync platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants