Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retpoline-related cfgs seems to be gone on nightly #46

Closed
HadrienG2 opened this issue Nov 22, 2024 · 2 comments
Closed

Retpoline-related cfgs seems to be gone on nightly #46

HadrienG2 opened this issue Nov 22, 2024 · 2 comments

Comments

@HadrienG2
Copy link

Per my nightly periodical CI log: https://github.com/HadrienG2/iterator_ilp/actions/runs/11963978141/job/33355466714 . Not sure if you can access it, if not here's the relevant part:

error: unexpected `cfg` condition value: `retpoline`
Error:  --> benches/benchmark.rs:9:1
  |
9 | #[multiversion(targets = "simd")]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `target_feature` are: `10e60`, `2e3`, `3e3r1`, `3e3r2`, `3e3r3`, `3e7`, `7e10`, `a`, `aclass`, `adx`, `aes`, `altivec`, `alu32`, `amx-bf16`, `amx-complex`, `amx-fp16`, `amx-int8`, `amx-tile`, `atomics`, `avx`, `avx2`, `avx512bf16`, `avx512bitalg`, `avx512bw`, `avx512cd`, `avx512dq`, `avx512f`, `avx512fp16`, `avx512ifma`, `avx512vbmi`, `avx512vbmi2`, `avx512vl`, `avx512vnni`, `avx512vp2intersect`, and `avx512vpopcntdq` and 251 more
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `-D unexpected-cfgs` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
  = note: this error originates in the attribute macro `multiversion` (in Nightly builds, run with -Z macro-backtrace for more info)

error: unexpected `cfg` condition value: `retpoline-indirect-branches`
Error:  --> benches/benchmark.rs:9:1
  |
9 | #[multiversion(targets = "simd")]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `target_feature` are: `10e60`, `2e3`, `3e3r1`, `3e3r2`, `3e3r3`, `3e7`, `7e10`, `a`, `aclass`, `adx`, `aes`, `altivec`, `alu32`, `amx-bf16`, `amx-complex`, `amx-fp16`, `amx-int8`, `amx-tile`, `atomics`, `avx`, `avx2`, `avx512bf16`, `avx512bitalg`, `avx512bw`, `avx512cd`, `avx512dq`, `avx512f`, `avx512fp16`, `avx512ifma`, `avx512vbmi`, `avx512vbmi2`, `avx512vl`, `avx512vnni`, `avx512vp2intersect`, and `avx512vpopcntdq` and 251 more
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: this error originates in the attribute macro `multiversion` (in Nightly builds, run with -Z macro-backtrace for more info)

error: unexpected `cfg` condition value: `retpoline-indirect-calls`
Error:  --> benches/benchmark.rs:9:1
  |
9 | #[multiversion(targets = "simd")]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `target_feature` are: `10e60`, `2e3`, `3e3r1`, `3e3r2`, `3e3r3`, `3e7`, `7e10`, `a`, `aclass`, `adx`, `aes`, `altivec`, `alu32`, `amx-bf16`, `amx-complex`, `amx-fp16`, `amx-int8`, `amx-tile`, `atomics`, `avx`, `avx2`, `avx512bf16`, `avx512bitalg`, `avx512bw`, `avx512cd`, `avx512dq`, `avx512f`, `avx512fp16`, `avx512ifma`, `avx512vbmi`, `avx512vbmi2`, `avx512vl`, `avx512vnni`, `avx512vp2intersect`, and `avx512vpopcntdq` and 251 more
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: this error originates in the attribute macro `multiversion` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `iterator_ilp` (bench "benchmark") due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

It seems multiversion will need some adaptations to work on newer nightlies and future beta/stable.

@calebzulawski
Copy link
Owner

I wonder if this is a regression in cfg checking, as far as I can tell those target features still exist.

@calebzulawski
Copy link
Owner

I think this is caused by rust-lang/rust#132577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants