Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidechain Limiter with 4 inputs segfaults if only 2 are connected #174

Closed
JohannesLorenz opened this issue May 14, 2018 · 1 comment
Closed

Comments

@JohannesLorenz
Copy link
Collaborator

The sidechain limiter has code that looks at all 4 input ports:

    inL = ins[0][offset];
    inR = ins[1][offset];
    scL = ins[2][offset];
    scR = ins[3][offset];

As 2 of them are optional, those should not be looked up if the respective ports are NULL. I guess the best fix would be to do it like in the sidechain compressor:

    scL = ins[2] ? ins[2][offset] : 0;
    scR = ins[3] ? ins[3][offset] : 0;

Thanks to @karmux for finding the segfault in an LMMS issue report.

@boomshop
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants