Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidechaining leveling is inactive if sidechain input is not used #175

Closed
JohannesLorenz opened this issue May 18, 2018 · 1 comment
Closed

Comments

@JohannesLorenz
Copy link
Collaborator

JohannesLorenz commented May 18, 2018

IIRC, if the parameter "sc route" is false, the sidechain signal is discarded, and the input sidechains itself:

    float leftAC  = inL;
    float rightAC = inR;
    float leftSC  = inL;
    float rightSC = inR;
    float leftMC  = inL;
    float rightMC = inR;

    if (*params[param_sc_route] > 0.5) {
        leftAC  = inL;
        rightAC = inR;
        leftSC  = in2L * *params[param_sc_level];
        rightSC = in2R * *params[param_sc_level];
        leftMC  = inL;
        rightMC = inR;
    }

Now, if the signal is sidechaining itself, it might still be desired to multiply inL and inR with *params[param_sc_level]. If the idea of "sc routing" set to false is that the input signal is also the sidechain signal, that sidechain signal should maybe also be multiplied with "sc level".

Background: LMMS can only handle 2 inputs, so many users "abuse" the "sc level" parameter for sidechaining: The sidechain signal feeds a peak controller, and the sc level is being connected to that controller. This worked with CALF 0.19, but fails with master (more exactly, since 83ce593 ).

Thanks to @karmux for finding.

@boomshop
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants