Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] PascalCase component names, reorganise directory structure #3749

Merged
merged 4 commits into from
Mar 21, 2016
Merged

[Core] PascalCase component names, reorganise directory structure #3749

merged 4 commits into from
Mar 21, 2016

Conversation

mbrookes
Copy link
Member

  • PR passes current tests, docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Reorganise and PascalCase component names. Incorporates #3682.

With some additional work on our build process to publish from within lib (and updating the docs site build so the examples have matching paths), this PR substantially addresses #2679.

Closes #3670, closes #2970.

(#2697, Rename of LeftNav to follow in a separate PR).

@nathanmarks
Copy link
Member

@mbrookes
Copy link
Member Author

Thanks, yes, they were already locally - it was more a question of getting git to recognise directory name changes so that the remote is correct.

There were a bunch of others, but I've finally got it to play along. 😄

@cgestes
Copy link
Contributor

cgestes commented Mar 21, 2016

@mbrookes would this config of git helps:

git config core.ignorecase false

@mbrookes
Copy link
Member Author

@cgestes - thanks, yes, it might well have done if I'd set it before starting this PR. 😄

@nathanmarks
Copy link
Member

Looks good to me 👍

@mbrookes This was fun to debug 😄 oh git oh git...

nathanmarks added a commit that referenced this pull request Mar 21, 2016
[Core] PascalCase component names, reorganise directory structure
@nathanmarks nathanmarks merged commit 0295fbe into mui:master Mar 21, 2016
@mbrookes mbrookes deleted the reorg-phase2 branch January 20, 2018 22:35
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Folder structure proposal [Popover] rename popover-animation-from-top
5 participants