-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable material community icons #3688
Comments
Hey @RichardLindhout, according to the Icons doc if you don't want to instal
Also according to point no 4:
|
Yes I did that but on some components it does not use this settings icon |
I see, had to overlook that information. Basically what we have to do is replace the |
Yes indeed :) |
Unofrtunately I handled that ticket wrongly and introduced the breaking change in I will try to re-investigate that topic and apply the correct changes. |
Is your feature request related to a problem? Please describe.
I don't want to add the material community icons
Describe the solution you'd like
I want the library to use the override Icon everywhere instead of somethings falling back to MaterialCommunityIcon (this should be done by the user). I want to overridde the material community icon en implement svg icons
Additional context
I believe this PR was not good: #1630
Example in RNP code: https://github.com/callstack/react-native-paper/blob/main/src/components/Checkbox/CheckboxAndroid.tsx#L146
Maybe we could provide an internal implementation of the MaterialCommunityIcon in the provider too?
The text was updated successfully, but these errors were encountered: